On 22.05.2023 19:08, Conor Dooley wrote:
On Sat, May 20, 2023 at 01:26:00PM +0200, Rafał Miłecki wrote:From: Rafał Miłecki <rafal@xxxxxxxxxx> Always use a minus/hyphen char to separate model from version. This unifies binding's "compatible" strings.Am I just being paranoid in thinking that software may have relied on the former naming scheme? On the other hand, my OCD really likes the change.
That's a very reasonable concern. TLDR: The risk of any breakage is extremely low due to Northstar CFE bootloader & projects with Northstar support. There are very few Northstar devices with bootloader other than CFE. All devices affected by this PATCH use CFE actually. CFE on Northstar has no support for DTS (DTB). DTB files are always appended to kernel on all affected devices. So problem of some DTB stored in bootloader getting out of sync with kernel / user-space is non-existent in this case. We still should consider a risk of some out-of-tree driver or just user-space checking for those compatible strings. I'm not aware of any project other than OpenWrt providing system images for those devices. There is some basic support in buildroot but it's quite dead. Even in OpenWrt case the only possibly affected device is Netgear R6300 V2. OpenWrt doesn't provide images for any of affected Luxul devices. So there isn't any known project this change can actually break. If there is one (very unlikely) it can still update its user-space or out of kernel driver while updating DTB. So while this change may be not the best approach (in general terms) in this case it's very unlikely to break anything.
Signed-off-by: Rafał Miłecki <rafal@xxxxxxxxxx> --- .../devicetree/bindings/arm/bcm/brcm,bcm4708.yaml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml index 454b0e93245d..cc34025fdc78 100644 --- a/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,bcm4708.yaml @@ -28,10 +28,10 @@ properties: - buffalo,wzr-1750dhp - linksys,ea6300-v1 - linksys,ea6500-v2 - - luxul,xap-1510v1 + - luxul,xap-1510-v1 - luxul,xwc-1000 - - netgear,r6250v1 - - netgear,r6300v2 + - netgear,r6250-v1 + - netgear,r6300-v2 - smartrg,sr400ac - brcm,bcm94708 - const: brcm,bcm4708 @@ -42,8 +42,8 @@ properties: - asus,rt-n18u - buffalo,wzr-600dhp2 - buffalo,wzr-900dhp - - luxul,xap-1410v1 - - luxul,xwr-1200v1 + - luxul,xap-1410-v1 + - luxul,xwr-1200-v1 - tplink,archer-c5-v2 - const: brcm,bcm47081 - const: brcm,bcm4708 @@ -72,7 +72,7 @@ properties: - luxul,xap-1610-v1 - luxul,xbr-4500-v1 - luxul,xwc-2000-v1 - - luxul,xwr-3100v1 + - luxul,xwr-3100-v1 - luxul,xwr-3150-v1 - netgear,r8500 - phicomm,k3 -- 2.35.3
