Hello Andrew, On 5/22/23 14:19, Andrew Lunn wrote: >>> Not exactly related to this patch, but please do not rely on this "max >>> speed mode" - please always ensure that you specify the phy-mode and >>> fixed-link settings for CPU and DSA ports in firmware. Thanks. >> >> I would like to make sure to fully understand your point: >> - when telling so specify phy-mode and fixed-link in firmware, you mean >> device-tree, right ? >> - when checking for code and execution flow, I observe that port_max_speed is >> always called and its output is always used to configure shared ports mode in >> mv88e6xxx driver. Are you telling that eventually, the whole mv88e6xxx driver >> should stop relying on port_max_speed_mode for shared ports ? > > Yes, the concept of port_max_speed_mode causes problems for PHYLINK, > and we want to remove it. Russell and i have been updating DT > descriptions adding fixed-link and phy-mode properties to all > mv88e6xxx systems so that it is not needed. Either at the end of this > cycle, or the beginning of the next we will change the code to > actually enforce this. Understood, thanks for clarification > > Andrew -- Alexis Lothoré, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
