On czw, 2014-11-27 at 18:45 +0000, Mark Brown wrote:
> On Thu, Nov 27, 2014 at 12:20:49PM +0100, Krzysztof Kozlowski wrote:
>
> > + constraints->ena_gpio = of_get_named_gpio_flags(np, "ena-gpios", 0,
> > + &gpio_flags);
> > + if (gpio_is_valid(constraints->ena_gpio)) {
>
> No, this isn't sensible - in what way would an enable control GPIO be a
> constraint? The whole reason we have separate constraint and config
> structures is that these are different things. Keep the GPIO setup in
> the configuration.
OK, I'll change it to config.
Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
