Hi Geert, Thanks for the feedback. > Subject: Re: [PATCH v4 09/11] regulator: dt-bindings: Add Renesas > RAA215300 PMIC bindings > > Hi Biju, > > On Thu, May 18, 2023 at 1:37 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > wrote: > > Document Renesas RAA215300 PMIC bindings. > > > > The RAA215300 is a high Performance 9-Channel PMIC supporting DDR > > Memory, with Built-In Charger and RTC. > > > > It supports DDR3, DDR3L, DDR4, and LPDDR4 memory power requirements. > > The internally compensated regulators, built-in Real-Time Clock (RTC), > > 32kHz crystal oscillator, and coin cell battery charger provide a > > highly integrated, small footprint power solution ideal for > > System-On-Module (SOM) applications. A spread spectrum feature > > provides an ease-of-use solution for noise-sensitive audio or RF > > applications. > > > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > --- > > v3->v4: > > * Moved bindings from mfd->regulator. > > * Dropped minItems from reg. > > * Dropped renesas,rtc-enabled property and instead used clock-names > property > > to find RTC is enabled or not. > > * Added reg-names in required property. > > * Updated the example. > > Thanks for your patch! > > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/regulator/renesas,raa215300.ya > > +++ ml > > @@ -0,0 +1,84 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2 > > +--- > > +$id: > > +title: Renesas RAA215300 Power Management Integrated Circuit (PMIC) > > + > > +maintainers: > > + - Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > + > > +description: | > > + The RAA215300 is a high-performance, low-cost 9-channel PMIC > > +designed for > > + 32-bit and 64-bit MCU and MPU applications. It supports DDR3, > > +DDR3L, DDR4, > > + and LPDDR4 memory power requirements. The internally compensated > > +regulators, > > + built-in Real-Time Clock (RTC), 32kHz crystal oscillator, and coin > > +cell > > + battery charger provide a highly integrated, small footprint power > > +solution > > + ideal for System-On-Module (SOM) applications. A spread spectrum > > +feature > > + provides an ease-of-use solution for noise-sensitive audio or RF > applications. > > + > > + This device exposes two devices via I2C. One for the integrated RTC > > + IP, and one for everything else. > > + > > + Link to datasheet: > > + > > + https://www.renesas.com/in/en/products/power-power-management/multi- > > + channel-power-management-ics-pmics/ssdsoc-power-management-ics-pmic- > > + and-pmus/raa215300-high-performance-9-channel-pmic-supporting-ddr-me > > + mory-built-charger-and-rtc > > + > > +properties: > > + compatible: > > + enum: > > + - renesas,raa215300 > > + > > + reg: > > + maxItems: 2 > > + > > + reg-names: > > + items: > > + - const: main > > + - const: rtc > > + > > + interrupts: > > + maxItems: 1 > > + > > + clocks: > > + maxItems: 1 > > Perhaps add a description to make it clear that not providing clocks is > supported, and means the RTC is disabled? Agreed. > > > + > > + clock-names: > > + description: | > > + Use xin, if connected to an external crystal. > > + Use clkin, if connected to an external clock signal. > > + oneOf: > > + - items: > > + - const: xin > > + - items: > > + - const: clkin > > Please replace oneOf+items by enum. OK. Cheers, Biju > > > + > > +required: > > + - compatible > > + - reg > > + - reg-names
