On Wed, 17 May 2023 18:25:07 +0100 Conor Dooley <conor@xxxxxxxxxx> wrote: > On Wed, May 17, 2023 at 11:07:46AM -0400, Hugo Villeneuve wrote: > > From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx> > > > > Some variants in this series of uart controllers have GPIO pins that > > are shared between GPIO and modem control lines. > > > > The pin mux mode (GPIO or modem control lines) can be set for each > > ports (channels) supported by the variant. > > > > This adds a property to the device tree to set the GPIO pin mux to > > modem control lines on selected ports if needed. > > > > Signed-off-by: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx> > > --- > > .../bindings/serial/nxp,sc16is7xx.txt | 28 +++++++++++++++++++ > > 1 file changed, 28 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt > > index 0fa8e3e43bf8..426b7285ad50 100644 > > --- a/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt > > +++ b/Documentation/devicetree/bindings/serial/nxp,sc16is7xx.txt > > @@ -23,6 +23,9 @@ Optional properties: > > 1 = active low. > > - irda-mode-ports: An array that lists the indices of the port that > > should operate in IrDA mode. > > +- modem-control-line-ports: An array that lists the indices of the port that > > + should have shared GPIO lines configured as modem > > + control lines. > > If this is an NXP specific property, should it not have an nxp, vendor > prefix? Yes, I will resubmit a V2 with nxp vendor prefix. Hugo.