On 17/05/2023 18:40, Konrad Dybcio wrote: > Add device tree bindings for the graphics clock controller on Qualcomm > Technology Inc's SM8450 SoCs. > > Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> > --- > .../bindings/clock/qcom,sm8450-gpucc.yaml | 73 ++++++++++++++++++++++ > include/dt-bindings/clock/qcom,sm8450-gpucc.h | 48 ++++++++++++++ > include/dt-bindings/reset/qcom,sm8450-gpucc.h | 20 ++++++ > 3 files changed, 141 insertions(+) > > diff --git a/Documentation/devicetree/bindings/clock/qcom,sm8450-gpucc.yaml b/Documentation/devicetree/bindings/clock/qcom,sm8450-gpucc.yaml > new file mode 100644 > index 000000000000..ad913b2daf0c > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/qcom,sm8450-gpucc.yaml > @@ -0,0 +1,73 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/qcom,sm8450-gpucc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Graphics Clock & Reset Controller on SM8450 > + > +maintainers: > + - Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> > + > +description: | > + Qualcomm graphics clock control module provides the clocks, resets and power > + domains on Qualcomm SoCs. > + > + See also:: > + include/dt-bindings/clock/qcom,sm8450-gpucc.h > + include/dt-bindings/reset/qcom,sm8450-gpucc.h > + > +properties: > + compatible: > + enum: > + - qcom,sm8450-gpucc > + > + clocks: > + items: > + - description: Board XO source > + - description: GPLL0 main branch source > + - description: GPLL0 div branch source > + > + '#clock-cells': > + const: 1 > + > + '#reset-cells': > + const: 1 > + > + '#power-domain-cells': > + const: 1 > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg If there is going to be new version: Keep the same order as in properties:, so if reg is not second there, neither should be here. In any case: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof
