Re: [PATCH] ARM: dts: stm32: fix several DT warnings on stm32mp15

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 

On 5/16/23 18:04, Alexandre TORGUE wrote:
> Hi Raphael
>
> On 5/16/23 15:25, Raphael Gallais-Pou wrote:
>> Several warnings regarding LTDC and DSI on stm32mp15* device-trees remains.
>>
>> Those concern:
>>    * "#size-cells" and "#address-cells" wrongly used
>>    * residual "reg" property appearing on endpoints where it could be
>>      avoided
>>
>> Signed-off-by: Raphael Gallais-Pou <raphael.gallais-pou@xxxxxxxxxxx>
>> ---
>
> Thanks to cleanup the last W=1 issues on stm32 MPU boards. It seems that your
> patch introduces YAML validation regression for some boards. Can you check
> this point please ?
>
> stm32mp157a-icore-stm32mp1-ctouch2-of10.dtb: dsi@5a000000: '#address-cells' is
> a required property
>     From schema:
> /local/home/frq08678/STLINUX/kernel/my-kernel/stm32/Documentation/devicetree/bindings/display/st,stm32-dsi.yaml
>
> stm32mp157a-icore-stm32mp1-edimm2.2.dtb: dsi@5a000000: '#address-cells' is a
> required property
>     From schema:
> /local/home/frq08678/STLINUX/kernel/my-kernel/stm32/Documentation/devicetree/bindings/display/st,stm32-dsi.yaml

Hi Alex,


This is due to the properties #address-cells and #size-cells being required in
the YAML file. I will make a second patch in a serie to order those things out.


Thanks,

Raphaël


>
> alex
>
>
>>   arch/arm/boot/dts/stm32mp151.dtsi                         | 5 -----
>>   arch/arm/boot/dts/stm32mp157.dtsi                         | 7 -------
>>   .../boot/dts/stm32mp157a-icore-stm32mp1-ctouch2-of10.dts  | 6 ++++--
>>   arch/arm/boot/dts/stm32mp157a-icore-stm32mp1-edimm2.2.dts | 6 ++++--
>>   .../dts/stm32mp157a-microgea-stm32mp1-microdev2.0-of7.dts | 3 +--
>>   arch/arm/boot/dts/stm32mp157c-dk2.dts                     | 8 ++++++++
>>   arch/arm/boot/dts/stm32mp157c-ev1.dts                     | 8 ++++++--
>>   arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts                 | 3 +--
>>   arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi        | 6 +-----
>>   arch/arm/boot/dts/stm32mp15xx-dkx.dtsi                    | 3 +--
>>   10 files changed, 26 insertions(+), 29 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/stm32mp151.dtsi
>> b/arch/arm/boot/dts/stm32mp151.dtsi
>> index 664825418c32..0dc46fd9c269 100644
>> --- a/arch/arm/boot/dts/stm32mp151.dtsi
>> +++ b/arch/arm/boot/dts/stm32mp151.dtsi
>> @@ -1529,11 +1529,6 @@ ltdc: display-controller@5a001000 {
>>               clock-names = "lcd";
>>               resets = <&rcc LTDC_R>;
>>               status = "disabled";
>> -
>> -            port {
>> -                #address-cells = <1>;
>> -                #size-cells = <0>;
>> -            };
>>           };
>>             iwdg2: watchdog@5a002000 {
>> diff --git a/arch/arm/boot/dts/stm32mp157.dtsi
>> b/arch/arm/boot/dts/stm32mp157.dtsi
>> index 54e73ccea446..5e733cd16ff9 100644
>> --- a/arch/arm/boot/dts/stm32mp157.dtsi
>> +++ b/arch/arm/boot/dts/stm32mp157.dtsi
>> @@ -24,14 +24,7 @@ dsi: dsi@5a000000 {
>>               clock-names = "pclk", "ref", "px_clk";
>>               resets = <&rcc DSI_R>;
>>               reset-names = "apb";
>> -            #address-cells = <1>;
>> -            #size-cells = <0>;
>>               status = "disabled";
>> -
>> -            ports {
>> -                #address-cells = <1>;
>> -                #size-cells = <0>;
>> -            };
>>           };
>>       };
>>   };
>> diff --git a/arch/arm/boot/dts/stm32mp157a-icore-stm32mp1-ctouch2-of10.dts
>> b/arch/arm/boot/dts/stm32mp157a-icore-stm32mp1-ctouch2-of10.dts
>> index 9a2a4bc7d079..4279b26547df 100644
>> --- a/arch/arm/boot/dts/stm32mp157a-icore-stm32mp1-ctouch2-of10.dts
>> +++ b/arch/arm/boot/dts/stm32mp157a-icore-stm32mp1-ctouch2-of10.dts
>> @@ -49,6 +49,9 @@ &dsi {
>>       phy-dsi-supply = <&reg18>;
>>         ports {
>> +        #address-cells = <1>;
>> +        #size-cells = <0>;
>> +
>>           port@0 {
>>               reg = <0>;
>>               dsi_in: endpoint {
>> @@ -104,8 +107,7 @@ &ltdc {
>>       status = "okay";
>>         port {
>> -        ltdc_ep0_out: endpoint@0 {
>> -            reg = <0>;
>> +        ltdc_ep0_out: endpoint {
>>               remote-endpoint = <&dsi_in>;
>>           };
>>       };
>> diff --git a/arch/arm/boot/dts/stm32mp157a-icore-stm32mp1-edimm2.2.dts
>> b/arch/arm/boot/dts/stm32mp157a-icore-stm32mp1-edimm2.2.dts
>> index 390ee8c05754..efba54289820 100644
>> --- a/arch/arm/boot/dts/stm32mp157a-icore-stm32mp1-edimm2.2.dts
>> +++ b/arch/arm/boot/dts/stm32mp157a-icore-stm32mp1-edimm2.2.dts
>> @@ -49,6 +49,9 @@ &dsi {
>>       phy-dsi-supply = <&reg18>;
>>         ports {
>> +        #address-cells = <1>;
>> +        #size-cells = <0>;
>> +
>>           port@0 {
>>               reg = <0>;
>>               dsi_in_ltdc: endpoint {
>> @@ -104,8 +107,7 @@ &ltdc {
>>       status = "okay";
>>         port {
>> -        ltdc_out_dsi: endpoint@0 {
>> -            reg = <0>;
>> +        ltdc_out_dsi: endpoint {
>>               remote-endpoint = <&dsi_in_ltdc>;
>>           };
>>       };
>> diff --git
>> a/arch/arm/boot/dts/stm32mp157a-microgea-stm32mp1-microdev2.0-of7.dts
>> b/arch/arm/boot/dts/stm32mp157a-microgea-stm32mp1-microdev2.0-of7.dts
>> index 0d7560ba2950..5116a7785201 100644
>> --- a/arch/arm/boot/dts/stm32mp157a-microgea-stm32mp1-microdev2.0-of7.dts
>> +++ b/arch/arm/boot/dts/stm32mp157a-microgea-stm32mp1-microdev2.0-of7.dts
>> @@ -81,8 +81,7 @@ &ltdc {
>>       status = "okay";
>>         port {
>> -        ltdc_ep0_out: endpoint@0 {
>> -            reg = <0>;
>> +        ltdc_ep0_out: endpoint {
>>               remote-endpoint = <&panel_in>;
>>           };
>>       };
>> diff --git a/arch/arm/boot/dts/stm32mp157c-dk2.dts
>> b/arch/arm/boot/dts/stm32mp157c-dk2.dts
>> index ab13e340f4ef..4bef2300ed7c 100644
>> --- a/arch/arm/boot/dts/stm32mp157c-dk2.dts
>> +++ b/arch/arm/boot/dts/stm32mp157c-dk2.dts
>> @@ -31,10 +31,15 @@ &cryp1 {
>>   };
>>     &dsi {
>> +    #address-cells = <1>;
>> +    #size-cells = <0>;
>>       status = "okay";
>>       phy-dsi-supply = <&reg18>;
>>         ports {
>> +        #address-cells = <1>;
>> +        #size-cells = <0>;
>> +
>>           port@0 {
>>               reg = <0>;
>>               dsi_in: endpoint {
>> @@ -82,6 +87,9 @@ &ltdc {
>>       status = "okay";
>>         port {
>> +        #address-cells = <1>;
>> +        #size-cells = <0>;
>> +
>>           ltdc_ep1_out: endpoint@1 {
>>               reg = <1>;
>>               remote-endpoint = <&dsi_in>;
>> diff --git a/arch/arm/boot/dts/stm32mp157c-ev1.dts
>> b/arch/arm/boot/dts/stm32mp157c-ev1.dts
>> index ba8e9d9a42fa..961e85b07a5e 100644
>> --- a/arch/arm/boot/dts/stm32mp157c-ev1.dts
>> +++ b/arch/arm/boot/dts/stm32mp157c-ev1.dts
>> @@ -101,9 +101,14 @@ dcmi_0: endpoint {
>>     &dsi {
>>       phy-dsi-supply = <&reg18>;
>> +    #address-cells = <1>;
>> +    #size-cells = <0>;
>>       status = "okay";
>>         ports {
>> +        #address-cells = <1>;
>> +        #size-cells = <0>;
>> +
>>           port@0 {
>>               reg = <0>;
>>               dsi_in: endpoint {
>> @@ -239,8 +244,7 @@ &ltdc {
>>       status = "okay";
>>         port {
>> -        ltdc_ep0_out: endpoint@0 {
>> -            reg = <0>;
>> +        ltdc_ep0_out: endpoint {
>>               remote-endpoint = <&dsi_in>;
>>           };
>>       };
>> diff --git a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
>> b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
>> index 407ed3952f75..eada9cf257be 100644
>> --- a/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
>> +++ b/arch/arm/boot/dts/stm32mp157c-lxa-mc1.dts
>> @@ -161,8 +161,7 @@ &ltdc {
>>       status = "okay";
>>         port {
>> -        ltdc_ep0_out: endpoint@0 {
>> -            reg = <0>;
>> +        ltdc_ep0_out: endpoint {
>>               remote-endpoint = <&panel_input>;
>>           };
>>       };
>> diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi
>> b/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi
>> index 50af4a27d6be..a564063b8f5a 100644
>> --- a/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi
>> +++ b/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi
>> @@ -330,11 +330,7 @@ &ltdc {
>>       status = "okay";
>>         port {
>> -        #address-cells = <1>;
>> -        #size-cells = <0>;
>> -
>> -        ltdc_ep0_out: endpoint@0 {
>> -            reg = <0>;
>> +        ltdc_ep0_out: endpoint {
>>               remote-endpoint = <&adv7513_in>;
>>           };
>>       };
>> diff --git a/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi
>> b/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi
>> index 0f1110e42c93..a6e2e20f12fa 100644
>> --- a/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi
>> +++ b/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi
>> @@ -457,8 +457,7 @@ &ltdc {
>>       status = "okay";
>>         port {
>> -        ltdc_ep0_out: endpoint@0 {
>> -            reg = <0>;
>> +        ltdc_ep0_out: endpoint {
>>               remote-endpoint = <&sii9022_in>;
>>           };
>>       };
>
[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]

  Powered by Linux