Hello,
If I understood you correctly you'd prefer it to be named
fannal,c3004.yaml? My logic is that if more panels were to be added that
means that each one would have yaml files that would look exactly the
same with the same user.
Best regards,
Paulo
On 5/17/23 09:03, Krzysztof Kozlowski wrote:
On 17/05/2023 00:13, Paulo Pavacic wrote:
Hello, thank you for your time to review this patch and sorry for not
addressing all of the concerns, it was done unintentionally. This is
my first contribution to the Linux kernel and it is quite a process.
I have run those two scripts and haven't received any errors I have
latest master cloned so I will check what I did wrong.
The thing I would like to get approval on before I try anything else
is the name 'panel-mipi-dsi-bringup':
Still wrong filename. You did not respond to my previous comments, so I
don't really understand what's this.
Judging by compatible, this should be fannal,c3004.yaml
If not, explain please.
Missing user of the bindings - driver or DTS. Please sent patches together as patchset.
I wasn't sure how to name it and this name seemed fit. I'm not sure
how to be concise about this, but here is the full story as to why I
have done that:
I got a task to enable panel for which working driver wasn't
available. I have started testing raydium driver and modifying parts
of it until I got it working.
Driver was modified quite a lot, new functions, macros and structures
were added which resulted in a new driver.
Therefore I have made a simple driver which I have submitted for a
review which will probably be rejected now due tomany reasons I have
noticed after sending it:
https://lore.kernel.org/lkml/CAO9szn03msW6pu37Zws5EaFGL10rjp9ugPdCuDvOPuQRU72gVQ@xxxxxxxxxxxxxx/T/
While talking with manufacturers of the panel I have figured out that
they aren't that familiar with the Linux kernel.
They had previously only enabled it on bare metal (PLA?) and provided
me with the initialization sequences. Initialization sequences are hex
values sent over MIPI DSI to initialize panel controller.
Initialization sequences sometimes also require delays after certain
commands and for different panels it can be very different.
I believe I have simplified it so that someone can follow comments
inside of the driver and try to enable mipi dsi panel by copy pasting
initialization code from bare metal system and doing minor
modifications.
Since I have targeted this at people who need to enable their panels
for the first time name seemed okay. I thought that since there is
panel-simple.yml that panel-mipi-dsi-bringup.yml would be acceptable
name.
Bindings are for hardware, not driver, so they describe the hardware panel.
Best regards,
Krzysztof
