On Tue, Nov 18, 2014 at 4:11 AM, Alexandre Courbot <gnurou@xxxxxxxxx> wrote:
> On Mon, Nov 17, 2014 at 11:30 PM, Geert Uytterhoeven
> <geert+renesas@xxxxxxxxx> wrote:
>> - ret = of_alias_get_id(pdev->dev.of_node, "gpio");
>> - if (ret < 0) {
>> - dev_err(&pdev->dev, "Couldn't get OF id\n");
>> - goto err0;
>> - }
>> - pdata->gpio_base = ret * 32; /* 32 GPIOs per instance */
>> + pdata->gpio_base = -1;
>
> User-space might break because of GPIO renumbering. Why not setting
> gpio_base to -1 when the property is not present (instead of
> triggering an error), keeping support for the property so existing
> boards remain safe, and marking the property as deprecated in the
> bindings documentation?
I don't like the way aliases are used here.
These bindings are undocumented by the way :( :( :(
I've applied it to wait and see what happens instead.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
