On 14.05.2023 21:58, André Apitzsch wrote:
> l8910 uses OCP8110 flash LED driver. Add it to the device tree.
>
> Tested-by: Stephan Gerhold <stephan@xxxxxxxxxxx>
> Signed-off-by: André Apitzsch <git@xxxxxxxxxxx>
> ---
> .../boot/dts/qcom/msm8916-longcheer-l8910.dts | 23 ++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dts b/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dts
> index b79e80913af9..81cebac117f1 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8916-longcheer-l8910.dts
> @@ -20,6 +20,21 @@ chosen {
> stdout-path = "serial0";
> };
>
> + flash-led-controller {
> + compatible = "ocs,ocp8110";
> + enable-gpios = <&msmgpio 49 GPIO_ACTIVE_HIGH>;
> + flash-gpios = <&msmgpio 119 GPIO_ACTIVE_HIGH>;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&camera_front_flash_default>;
property-n
property-names
please!
> +
> + flash_led: led {
> + function = LED_FUNCTION_FLASH;
> + color = <LED_COLOR_ID_WHITE>;
> + flash-max-timeout-us = <250000>;
> + };
> + };
> +
> gpio-keys {
> compatible = "gpio-keys";
>
> @@ -246,6 +261,14 @@ button_backlight_default: button-backlight-default-state {
> bias-disable;
> };
>
> + camera_front_flash_default: camera-front-flash-default-state {
> + pins = "gpio49", "gpio119";
> + function = "gpio";
> +
Unnecessary newline
LGTM otherwise!
Konrad
> + drive-strength = <2>;
> + bias-disable;
> + };
> +
> gpio_keys_default: gpio-keys-default-state {
> pins = "gpio107";
> function = "gpio";
>
> ---
> base-commit: 533c54547153d46c0bf99ac0e396bed71f760c03
> change-id: 20230514-x5_front_flash-c189e22b32fd
>
> Best regards,
