On 15/05/2023 18:22, Krzysztof Kozlowski wrote:
On 15/05/2023 18:15, Neil Armstrong wrote:
On 13/05/2023 20:32, Krzysztof Kozlowski wrote:
On 12/05/2023 15:11, Neil Armstrong wrote:
The Amlogic G12A, G12B & SM1 SoCs embeds a Synopsys DW-MIPI-DSI transceiver (ver 1.21a),
with a custom glue managing the IP resets, clock and data input similar to the DW-HDMI Glue
on the same Amlogic SoCs.
Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586
This message may be automatic, but context is always important when reviewing,
this commit message is a re-spin on v3 that was reviewed by rob but I decided to remove the review
tags since I added a new clock and did some other cleanups.
While the process describes "how the patch itself *should* be formatted", it's a best effort
and not a blocker.
Other issues are blockers.
I agree with that
I'll fix the wrapping since you pointed out, but referring to the submitting-patches.rst
file (from a very old v5.18-rc4 version) is kind of childish.
It's just a link stored in automated responses, what's here childish?
It's still valid in current cycle! Look:
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
What's the difference? Srsly, I can point you to submitting patches
without reference to specific line if you wish... Or you can check by
yourself.
I give the same reviews to so many people that have templates and Elixir
happens to be the only place allowing bookmarking specific line. Which
is helpful for beginners because the entire doc is huge.
I can make an exception for you and never paste direct links.
I value those kind of links for beginners and newcomers, really, it's a good
thing to do and we should all do the same.
But I always take in account who I'm reviewing, and adapt my comments,
I think it's sane to not appear as rude because we all forget to check
some stuff when send patches upstream, or at least I often forget...
Anyway, don't make exceptions or change your process for me, I'll live with it.
Neil
Best regards,
Krzysztof
