On 15/05/2023 12:13, Varadarajan Narayanan wrote: > From: Praveenkumar I <quic_ipkumar@xxxxxxxxxxx> > > Qualcomm IPQ9574 has tsens v2.3.1 block, which is similar to IPQ8074 tsens. > > Signed-off-by: Praveenkumar I <quic_ipkumar@xxxxxxxxxxx> > Signed-off-by: Varadarajan Narayanan <quic_varada@xxxxxxxxxxx> > --- > [v3]: > Fix dt_binding_check & dtbs_check errors (Used > Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml > as reference/example) > > Drop 'Acked-by: Rob Herring' as suggested in review > > [v2]: > Thanks to Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > for the tip to make qcom,ipq8074-tsens as fallback. > --- > Documentation/devicetree/bindings/thermal/qcom-tsens.yaml | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > index d9aa54c..57e3908 100644 > --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > @@ -19,6 +19,11 @@ description: | > properties: > compatible: > oneOf: > + - const: qcom,tsens-v0_1 > + - const: qcom,tsens-v1 > + - const: qcom,tsens-v2 Nope, these are not correct. > + - const: qcom,ipq8074-tsens Also nope, this is already there. > + > - description: msm8960 TSENS based > items: > - enum: > @@ -66,8 +71,10 @@ properties: > - const: qcom,tsens-v2 > > - description: v2 of TSENS with combined interrupt > - enum: > - - qcom,ipq8074-tsens Why? > + items: > + - enum: > + - qcom,ipq9574-tsens > + - const: qcom,ipq8074-tsens > > reg: > items: > @@ -279,6 +286,7 @@ allOf: > contains: > enum: > - qcom,ipq8074-tsens > + - qcom,ipq9574-tsens Not needed, drop. > then: > properties: > interrupts: > @@ -294,6 +302,7 @@ allOf: > contains: > enum: > - qcom,ipq8074-tsens > + - qcom,ipq9574-tsens Ditto. Best regards, Krzysztof
