Il 11/05/23 18:29, amergnat@xxxxxxxxxxxx ha scritto:
From: Fabien Parent <fparent@xxxxxxxxxxxx> On downstream, we observe that the MSDC IP (used by the emmc, the micro SD card and the WiFi) isn't working properly if the VMC regulator is shutdown. Make sure it is always on.
I don't understand the power tree of this board: if your VQMMC is VIO18 and *not* VMC, why is that required? The real question is if we're facing one more supply as requirement for newer MediaTek SoCs and whether it would be a better idea to add that to the actual driver (and/or as a power domain supply!!!) to both better represent the power tree and to eventually allow deep power saving states. Regards, Angelo
Signed-off-by: Fabien Parent <fparent@xxxxxxxxxxxx> Tested-by: Kevin Hilman <khilman@xxxxxxxxxxxx> Signed-off-by: Alexandre Mergnat <amergnat@xxxxxxxxxxxx> --- arch/arm64/boot/dts/mediatek/mt8365-evk.dts | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8365-evk.dts b/arch/arm64/boot/dts/mediatek/mt8365-evk.dts index 752007d0598e..5d69b39c8746 100644 --- a/arch/arm64/boot/dts/mediatek/mt8365-evk.dts +++ b/arch/arm64/boot/dts/mediatek/mt8365-evk.dts @@ -137,6 +137,11 @@ &mt6357_pmic { #interrupt-cells = <2>; };+/* Needed by MSDC IP */+&mt6357_vmc_reg { + regulator-always-on; +}; + &pio { gpio_keys: gpio-keys-pins { pins {
