On 15/05/2023 07:43, Yangtao Li wrote: > Add devicetree binding document and related header file > for the T-HEAD TH1520 clock. > > Cc: Icenowy Zheng <uwu@xxxxxxxxxx> > Cc: Wei Fu <wefu@xxxxxxxxxx> > Cc: Jisheng Zhang <jszhang@xxxxxxxxxx> > Signed-off-by: Yangtao Li <frank.li@xxxxxxxx> > --- > .../bindings/clock/thead,th1520-ccu.yaml | 60 +++++++++++++++++++ > 1 file changed, 60 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/thead,th1520-ccu.yaml > > diff --git a/Documentation/devicetree/bindings/clock/thead,th1520-ccu.yaml b/Documentation/devicetree/bindings/clock/thead,th1520-ccu.yaml > new file mode 100644 > index 000000000000..c3e2d8c7efa6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/thead,th1520-ccu.yaml > @@ -0,0 +1,60 @@ > +# SPDX-License-Identifier: GPL-2.0 Dual license. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/thead,th1520-ccu.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: T-HEAD Clock Control Unit > + > +maintainers: > + - Jisheng Zhang <jszhang@xxxxxxxxxx> > + - Wei Fu <wefu@xxxxxxxxxx> > + - Yangtao Li <frank.li@xxxxxxxx> > + > + Stray blank line. > +properties: > + "#clock-cells": > + const: 1 > + > + "#reset-cells": > + const: 1 > + > + compatible: Compatible is always first property. > + enum: > + - thead,th1520-ccu > + > + reg: > + maxItems: 1 > + > + clocks: > + const: 2 > + items: > + - description: High Frequency Oscillator (usually at 24MHz) > + - description: Low Frequency Oscillator (usually at 32kHz) Does not look like you tested the bindings. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). I'll stop review. Best regards, Krzysztof
