On 15/05/2023 04:47, AS50 CTLin0 wrote: > On 5/14/2023 2:38 AM, Krzysztof Kozlowski wrote: >> On 12/05/2023 14:01, David Lin wrote: >>> Convert the NAU8824 audio CODEC bindings to DT schema. >>> >>> Signed-off-by: David Lin <CTLIN0@xxxxxxxxxxx> >>> --- >> Thank you for your patch. There is something to discuss/improve. >> >>> + >>> + nuvoton,sar-threshold-num: >>> + $ref: /schemas/types.yaml#/definitions/uint32 >>> + description: >>> + Number of buttons supported. >>> + minimum: 1 >>> + maximum: 4 >>> + default: 4 >>> + >>> + nuvoton,sar-threshold: >>> + $ref: /schemas/types.yaml#/definitions/uint32-array >>> + description: >>> + Impedance threshold for each button. Array that contains up to 8 buttons >>> + configuration. SAR value is calculated as >>> + SAR = 255 * MICBIAS / SAR_VOLTAGE * R / (2000 + R) where MICBIAS is >>> + configured by 'nuvoton,micbias-voltage', SAR_VOLTAGE is configured by >>> + 'nuvoton,sar-voltage', R - button impedance. >>> + Refer datasheet section 10.2 for more information about threshold >>> + calculation. >>> + minItems: 1 >>> + maxItems: 4 >> Your description mentions 8 buttons, so maybe it should be 8 here? Or >> description needs a fix? > Driver just handle maxima 4 buttons for general application, but the the > above description is truly hardware capability with 8 buttons support. Then it should be 8. Best regards, Krzysztof
