Hi Michal,
Thank you for the patch.
On Fri, May 12, 2023 at 01:40:33PM +0200, Michal Simek wrote:
> DP DMA has own power domain that's why describe required power-domain
> property.
>
> Signed-off-by: Michal Simek <michal.simek@xxxxxxx>
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
>
> Changes in v3:
> - make power-domains as required property
> - also update commit message
>
> Changes in v2:
> - rewrite commit message - requested by Krzysztof
>
> The commit b06112cd5e08 ("arm64: dts: zynqmp: Add power domain for the
> DisplayPort DMA controller") added this property already in Linux that's
> why the patch is also fixing dts_check warnings.
>
> In v2 I got ack from Krzysztof but not adding it because of additional
> discussion about required property in v3.
> https://lore.kernel.org/r/029ba923-d13e-ea7c-018d-95e179dda2e5@xxxxxxxxxx
>
> ---
> .../devicetree/bindings/dma/xilinx/xlnx,zynqmp-dpdma.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dpdma.yaml b/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dpdma.yaml
> index d6cbd95ec26d..2128f4645c98 100644
> --- a/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dpdma.yaml
> +++ b/Documentation/devicetree/bindings/dma/xilinx/xlnx,zynqmp-dpdma.yaml
> @@ -41,6 +41,9 @@ properties:
> clock-names:
> const: axi_clk
>
> + power-domains:
> + maxItems: 1
> +
> required:
> - "#dma-cells"
> - compatible
> @@ -48,12 +51,14 @@ required:
> - interrupts
> - clocks
> - clock-names
> + - power-domains
>
> additionalProperties: false
>
> examples:
> - |
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/power/xlnx-zynqmp-power.h>
>
> dma: dma-controller@fd4c0000 {
> compatible = "xlnx,zynqmp-dpdma";
> @@ -63,6 +68,7 @@ examples:
> clocks = <&dpdma_clk>;
> clock-names = "axi_clk";
> #dma-cells = <1>;
> + power-domains = <&zynqmp_firmware PD_DP>;
> };
>
> ...
--
Regards,
Laurent Pinchart
