On Wed, May 10, 2023 at 03:20:14PM +0800, Changhuang Liang wrote: > On 2023/5/10 15:06, Conor Dooley wrote: > > On Tue, May 09, 2023 at 06:53:07PM -0700, Changhuang Liang wrote: > >> + - starfive,jh7110-pmu > >> + - items: > >> + - enum: > >> + - starfive,jh7110-aon-syscon > >> + - const: syscon > > > > Unfortunately, this is not what was wanted. > > This syscon, of which power domain control is just one of the things that > > it can do, should be documented in > > Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml > > alongside it's brethern "starfive,jh7110-sys-syscon" & > > "starfive,jh7110-stg-syscon". > > > > That means that I don't need to modify this original yaml file? Does "this original" mean starfive,jh7100-pmu.yaml? If so then... > I just need to move current changes in this patch into > "Documentation/devicetree/bindings/soc/starfive/starfive,jh7110-syscon.yaml"? Correct. It makes most sense for that binding, as it depends on the pll binding (because it has a ref: to it), to go through the clock tree in Xingyu's series. I'll apply the driver changes once the binding has been applied. Thanks, Conor.
Attachment:
signature.asc
Description: PGP signature
