On Wednesday 26 November 2014 15:38:09 Dave Gerlach wrote:
> +
> +static const struct wkup_m3_wakeup_src wakeups[] = {
> + {.irq_nr = 35, .src = "USB0_PHY"},
> + {.irq_nr = 36, .src = "USB1_PHY"},
> + {.irq_nr = 40, .src = "I2C0"},
> + {.irq_nr = 41, .src = "RTC Timer"},
> + {.irq_nr = 42, .src = "RTC Alarm"},
> + {.irq_nr = 43, .src = "Timer0"},
> + {.irq_nr = 44, .src = "Timer1"},
> + {.irq_nr = 45, .src = "UART"},
> + {.irq_nr = 46, .src = "GPIO0"},
> + {.irq_nr = 48, .src = "MPU_WAKE"},
> + {.irq_nr = 49, .src = "WDT0"},
> + {.irq_nr = 50, .src = "WDT1"},
> + {.irq_nr = 51, .src = "ADC_TSC"},
> + {.irq_nr = 0, .src = "Unknown"},
> +};
>
This seems awfully specific to some SoC version, and not aware of
IRQ domains. It also seems to be only used in a dev_dbg statement,
so I guess you could just kill this off entirely.
> +static struct rproc *wkup_m3_get_rproc(struct device *dev)
> +{
> + struct device_node *node;
> + struct rproc *rp;
> +
> + node = of_parse_phandle(dev->of_node, "ti,rproc", 0);
> + if (!node)
> + return NULL;
> +
> + dev = bus_find_device(&platform_bus_type, NULL, node, match);
> + if (!dev)
> + return NULL;
> +
> + rp = dev_get_drvdata(dev);
> + return rp;
This is wrong on a number of levels. I suspect what you really want
is an interface exported from drivers/remoteproc that looks up
a 'struct rproc' and performs the necessary reference counting.
That one can just use of_find_node_by_phandle() to get to
a device_node and use that to look up the rproc device in
a linked list it maintains.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
