Re: [PATCH v7 1/3] dt-bindings: ufs: qcom: Add ICE phandle

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/05/2023 20:47, Krzysztof Kozlowski wrote:
> On 08/04/2023 23:40, Abel Vesa wrote:
>> Starting with SM8550, the ICE will have its own devicetree node
>> so add the qcom,ice property to reference it.
>>
>> Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx>
>> ---
>>
>> The v6 is here:
>> https://lore.kernel.org/all/20230407105029.2274111-3-abel.vesa@xxxxxxxxxx/
>>
>> Changes since v6:
>>  * Dropped the minItems for both the qcom,ice and the reg in the
>>    qcom,ice compatile subschema, like Krzysztof suggested
>>
>> Changes since v5:
>>  * dropped the sm8550 specific subschema and replaced it with one that
>>    mutually excludes the qcom,ice vs both the ICE specific reg range
>>    and the ICE clock
>>
>> Changes since v4:
>>  * Added check for sm8550 compatible w.r.t. qcom,ice in order to enforce
>>    it while making sure none of the other platforms are allowed to use it
>>
>> Changes since v3:
>>  * dropped the "and drop core clock" part from subject line
>>
>> Changes since v2:
>>  * dropped all changes except the qcom,ice property
>>
>>
>>  .../devicetree/bindings/ufs/qcom,ufs.yaml     | 24 +++++++++++++++++++
>>  1 file changed, 24 insertions(+)
>>
> 
> I see dt_binding_check errors after applying this patch. Are you sure
> this was tested?

False alarm, it was other patch in my tree.

This one is good.

Best regards,
Krzysztof




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux