On Fri, 5 May 2023 at 22:26, Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote: > > > > On 5.05.2023 11:29, Dmitry Baryshkov wrote: > > On Fri, 5 May 2023 at 11:23, Varadarajan Narayanan > > <quic_varada@xxxxxxxxxxx> wrote: > >> > >> Add LDO regulator node > > > > As this LDO is provided by the PMIC, it would be nice to know why it > > is modelled as an always-on regulator instead of the proper PMIC > > regulator. Up to now we were doing this only for the outstanding power > > rails like CX/MX or EBI. > (which we then stopped registering as regulators and started > to manage through rpm(h)pd drivers and the genpd framework) I mean having regulator-fixed s4a on sm8250 in addition to the CX genpd, because some of the parts really expect to have a regulator. But anyway, we are getting away from the subj. Let's wait for the answer from Varadarajan. > > Konrad > > > >> > >> Signed-off-by: Varadarajan Narayanan <quic_varada@xxxxxxxxxxx> > >> --- > >> Changes in v10: > >> - Add LDO regulator node > >> --- > >> arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts | 7 +++++++ > >> 1 file changed, 7 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > >> index bdc1434..1f5d14f 100644 > >> --- a/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > >> +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433.dts > >> @@ -60,6 +60,13 @@ > >> regulator-min-microvolt = <725000>; > >> regulator-max-microvolt = <1075000>; > >> }; > >> + > >> + mp5496_l2: l2 { > >> + regulator-min-microvolt = <1800000>; > >> + regulator-max-microvolt = <1800000>; > >> + regulator-boot-on; > >> + regulator-always-on; > >> + }; > >> }; > >> }; -- With best wishes Dmitry