On 05/05/2023 20:52, Frank Li wrote: > Add usb2-disconnect-threshold-microvolt property to address fake USB > disconnection issue during enumeration or suspend state for difference > platform. Use subject prefixes matching the subsystem (which you can get for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching). Two prefixes got wrong... It's not doc but it is dt-bindings. > > Signed-off-by: Frank Li <Frank.Li@xxxxxxx> > --- > Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml b/Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml > index 3a07285b5470..3c7f5b3f9211 100644 > --- a/Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/cdns,salvo-phy.yaml > @@ -31,6 +31,13 @@ properties: > "#phy-cells": > const: 0 > > + usb2-disconnect-threshold-microvolt: > + description: The microvolt threshold value utilized for detecting > + USB disconnection event. > + $ref: /schemas/types.yaml#/definitions/uint32 Does not look like you tested the bindings. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Drop ref. Add vendor prefix. > + enum: [575, 610, 645] > + default: 575 > + > required: > - compatible > - reg Best regards, Krzysztof
