Hi Krzysztof Kozlowski, Thanks for the feedback. > Subject: Re: [PATCH v2 1/5] dt-bindings: mfd: Add Renesas RAA215300 PMIC > bindings > > On 05/05/2023 19:25, Biju Das wrote: > > Document Renesas RAA215300 PMIC bindings. > > > > The RAA215300 is a high Performance 9-Channel PMIC supporting DDR > > Memory, with Built-In Charger and RTC. > > > > It supports DDR3, DDR3L, DDR4, and LPDDR4 memory power requirements. > > The internally compensated regulators, built-in Real-Time Clock (RTC), > > 32kHz crystal oscillator, and coin cell battery charger provide a > > highly integrated, small footprint power solution ideal for > > System-On-Module (SOM) applications. A spread spectrum feature > > provides an ease-of-use solution for noise-sensitive audio or RF > > applications. > > > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > --- > > RFC->v2: > > * Updated reg property > > * Added optional reg-names, interrupts and renesas,rtc-enabled > > properties. > > * Fixed the node name in the example > > * Dropped the cross link property renesas,raa215300-rtc. > > * Updated the example > > --- > > .../bindings/mfd/renesas,raa215300.yaml | 68 +++++++++++++++++++ > > 1 file changed, 68 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/mfd/renesas,raa215300.yaml > > > > diff --git > > a/Documentation/devicetree/bindings/mfd/renesas,raa215300.yaml > > b/Documentation/devicetree/bindings/mfd/renesas,raa215300.yaml > > new file mode 100644 > > index 000000000000..85cb4f0b5711 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mfd/renesas,raa215300.yaml > > @@ -0,0 +1,68 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > > +--- > > +$id: > > + > > +title: Renesas RAA215300 Power Management Integrated Circuit (PMIC) > > + > > +maintainers: > > + - Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > + > > +description: | > > + The RAA215300 is a high-performance, low-cost 9-channel PMIC > > +designed for > > + 32-bit and 64-bit MCU and MPU applications. It supports DDR3, > > +DDR3L, DDR4, > > + and LPDDR4 memory power requirements. The internally compensated > > +regulators, > > + built-in Real-Time Clock (RTC), 32kHz crystal oscillator, and coin > > +cell > > + battery charger provide a highly integrated, small footprint power > > +solution > > + ideal for System-On-Module (SOM) applications. A spread spectrum > > +feature > > + provides an ease-of-use solution for noise-sensitive audio or RF > applications. > > + > > + This device exposes two devices via I2C. One for the integrated RTC > > + IP, and one for everything else. > > + > > + Link to datasheet: > > + > > + https://www.renesas.com/in/en/products/power-power-management/multi- > > + channel-power-management-ics-pmics/ssdsoc-power-management-ics-pmic- > > + and-pmus/raa215300-high-performance-9-channel-pmic-supporting-ddr-me > > + mory-built-charger-and-rtc > > + > > +properties: > > + compatible: > > + enum: > > + - renesas,raa215300 > > + > > + reg: > > + minItems: 1 > > + maxItems: 2 > > + > > + reg-names: > > + items: > > + - const: main > > + - const: rtc > > + > > + interrupts: > > + maxItems: 1 > > + > > + renesas,rtc-enabled: > > + description: > > + To indicate RTC is enabled on the PMIC. > > "Enabled" by who or what? This looks like some policy, so Devicetree is not > a place for it. It is based on system design. System designers may chose not to populate built-in RTC by grounding XIN and XOUT pins. Do we need to add this info in description to make it clear?? Cheers, Biju > > > + type: boolean > > + > > +required: > > + - compatible > > + - reg > > > Best regards, > Krzysztof
