Hi Krzysztof,
On 5/4/23 10:42 PM, Bhupesh Sharma wrote:
On Wed, 3 May 2023 at 21:55, Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
On 02/05/2023 07:35, Bhupesh Sharma wrote:
'qcom,msm8996-qmp-usb3-phy.yaml' defines bindings for several PHYs
which predate USB -> USB+DP migration. Since SM6115 and QCM2290
nodes for USB QMP phy are being added to dtsi files by followup patches,
move these bindings instead to the newer style
'qcom,sc8280xp-qmp-usb3-uni-phy.yaml' file.
clock-names:
- items:
- - const: aux
- - const: ref
- - const: com_aux
- - const: pipe
+ maxItems: 4
power-domains:
maxItems: 1
@@ -71,6 +69,42 @@ required:
additionalProperties: false
+allOf:
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,qcm2290-qmp-usb3-phy
+ - qcom,sm6115-qmp-usb3-phy
+ then:
+ properties:
+ clocks:
+ maxItems: 4
+ clock-names:
+ items:
+ - const: cfg_ahb
+ - const: ref
+ - const: com_aux
+ - const: pipe
I am pretty sure I acked it and there were no changes here... but since
you did not include it, then lets keep the clock order the same as
sc8280xp. ABI is anyway affected, right?
Yes, I forgot to include your Ack in this version :(
Ok, I will fix the clock order in v11.
I just noticed that the clock orders are actually the same as sc8280xp.
The only clock diff between sm6115 and sc8280xp is actually 'cfg_ahb'
clock used by sm6115 instead of 'aux' used by sc8280xp.
So, the clock order for sc8280xp is:
+ - const: aux
+ - const: ref
+ - const: com_aux
+ - const: pipe
whereas the same for sm6115 is:
+ - const: cfg_ahb
+ - const: ref
+ - const: com_aux
+ - const: pipe
Or, am I missing something? If not, may be I can include your Ack to
help get this applied :)
Thanks,
Bhupesh
