On Fri, May 5, 2023 at 1:51 AM Rob Herring <robh@xxxxxxxxxx> wrote:
>
> On Tue, Apr 04, 2023 at 07:03:22PM +0100, Conor Dooley wrote:
> > From: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> >
> > Seemingly I mis-implemented the dependencies here. The OpenSBI docs only
> > point out that the "riscv,event-to-mhpmcounters property is mandatory if
> > riscv,event-to-mhpmevent is present". It never claims that
> > riscv,event-to-mhpmcounters requires riscv,event-to-mhpmevent.
> >
> > Drop the dependency of riscv,event-to-mhpmcounters on
> > riscv,event-to-mhpmevent.
> >
> > Fixes: 7e38085d9c59 ("dt-bindings: riscv: add SBI PMU event mappings")
> > Signed-off-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> > ---
> >
> > Atish, I'm not 100% on this one but I noticed it while doing dt-validate
> > on a dump of the qemu virt machine which doesn't use the
> > event-to-mhpmevent property.
Yes. That's correct. virt machine uses default encoding specified by
the SBI PMU spec.
Hence, event-to-mhpmevent is not used.
>
> Waiting for comments before I apply this...
>
Sorry for the delay. Not sure why this did not show up in my gmail.
Probably due to all the bouncing issues going on.
Reviewed-by: Atish Patra <atishp@xxxxxxxxxxxx>
> >
> > CC: Rob Herring <robh+dt@xxxxxxxxxx>
> > CC: Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>
> > CC: Paul Walmsley <paul.walmsley@xxxxxxxxxx>
> > CC: Palmer Dabbelt <palmer@xxxxxxxxxxx>
> > CC: Atish Patra <atishp@xxxxxxxxxxxx>
> > CC: Andrew Jones <ajones@xxxxxxxxxxxxxxxx>
> > CC: devicetree@xxxxxxxxxxxxxxx
> > CC: linux-riscv@xxxxxxxxxxxxxxxxxxx
> > CC: linux-kernel@xxxxxxxxxxxxxxx
> > ---
> > Documentation/devicetree/bindings/perf/riscv,pmu.yaml | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/perf/riscv,pmu.yaml b/Documentation/devicetree/bindings/perf/riscv,pmu.yaml
> > index a55a4d047d3f..c8448de2f2a0 100644
> > --- a/Documentation/devicetree/bindings/perf/riscv,pmu.yaml
> > +++ b/Documentation/devicetree/bindings/perf/riscv,pmu.yaml
> > @@ -91,7 +91,6 @@ properties:
> >
> > dependencies:
> > "riscv,event-to-mhpmevent": [ "riscv,event-to-mhpmcounters" ]
> > - "riscv,event-to-mhpmcounters": [ "riscv,event-to-mhpmevent" ]
> >
> > required:
> > - compatible
> > --
> > 2.39.2
> >
