On 5/3/23 09:28, Krzysztof Kozlowski wrote: > On 01/05/2023 10:43, Cristian Ciocaltea wrote: >> Document the OTP memory found on Rockchip RK3588 SoC. >> >> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@xxxxxxxxxxxxx> >> --- >> .../bindings/nvmem/rockchip-otp.yaml | 71 ++++++++++++++++--- >> 1 file changed, 60 insertions(+), 11 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/nvmem/rockchip-otp.yaml b/Documentation/devicetree/bindings/nvmem/rockchip-otp.yaml >> index 658ceed14ee2..84a11382c6e7 100644 >> --- a/Documentation/devicetree/bindings/nvmem/rockchip-otp.yaml >> +++ b/Documentation/devicetree/bindings/nvmem/rockchip-otp.yaml >> @@ -9,34 +9,31 @@ title: Rockchip internal OTP (One Time Programmable) memory >> maintainers: >> - Heiko Stuebner <heiko@xxxxxxxxx> >> >> -allOf: >> - - $ref: nvmem.yaml# >> - >> properties: >> compatible: >> enum: >> - rockchip,px30-otp >> - rockchip,rk3308-otp >> + - rockchip,rk3588-otp >> >> reg: >> maxItems: 1 >> >> clocks: >> minItems: 3 >> - maxItems: 3 >> + maxItems: 4 >> >> clock-names: >> - items: >> - - const: otp >> - - const: apb_pclk >> - - const: phy >> + minItems: 3 >> + maxItems: 4 >> >> resets: >> - maxItems: 1 >> + minItems: 1 >> + maxItems: 3 >> >> reset-names: >> - items: >> - - const: phy >> + minItems: 1 >> + maxItems: 3 >> >> required: >> - compatible >> @@ -46,6 +43,58 @@ required: >> - resets >> - reset-names >> >> +allOf: >> + - $ref: nvmem.yaml# >> + >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - rockchip,px30-otp >> + - rockchip,rk3308-otp >> + then: >> + properties: >> + clocks: >> + minItems: 3 >> + maxItems: 3 >> + clock-names: >> + items: >> + - const: otp >> + - const: apb_pclk >> + - const: phy >> + resets: >> + maxItems: 1 >> + reset-names: >> + items: >> + - const: phy >> + >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - rockchip,rk3588-otp >> + then: >> + properties: >> + clocks: >> + minItems: 4 >> + maxItems: 4 >> + clock-names: >> + items: >> + - const: otpc >> + - const: apb >> + - const: arb >> + - const: phy > > Keep the same order of clocks as in older variants, so you can keep the > list in top-level place and here only minItems: 4. > >> + resets: >> + minItems: 1 >> + maxItems: 3 >> + reset-names: >> + items: >> + - const: otpc > > Shouldn't this be phy? It seems there is no reset for PHY, or at least I couldn't find any reference in the RK3588 TRM, nor in the downstream driver implementation. Thanks for reviewing! I will prepare v2 with all the requested changes. Kind regards, Cristian
