On Tue, May 02, 2023 at 03:02:49PM +0000, Shubhi Garg wrote:
[...]
> diff --git a/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dts b/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dts
> new file mode 100644
> index 000000000000..3ac8070918bb
> --- /dev/null
> +++ b/arch/arm64/boot/dts/nvidia/tegra234-p3740-0002+p3701-0008.dts
> @@ -0,0 +1,155 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/dts-v1/;
> +
> +#include <dt-bindings/input/linux-event-codes.h>
> +#include <dt-bindings/input/gpio-keys.h>
> +#include "tegra234-p3701-0008.dtsi"
> +#include "tegra234-p3740-0002.dtsi"
> +
> +/ {
> + model = "NVIDIA IGX Orin Development Kit";
> + compatible = "nvidia,p3740-0002+p3701-0008", "nvidia,p3701-0008", "nvidia,tegra234";
> +
> + bus@0 {
> + host1x@13e00000 {
> + nvdec@15480000 {
> + status = "okay";
> + };
> + };
> +
> + pcie@140e0000 {
> + status = "okay";
> + vddio-pex-ctl-supply = <&vdd_1v8_ls>;
> + phys = <&p2u_gbe_4>, <&p2u_gbe_5>;
> + phy-names = "p2u-0", "p2u-1";
> + };
> +
> + pcie@14100000 {
> + status = "okay";
> + vddio-pex-ctl-supply = <&vdd_1v8_ao>;
> + phys = <&p2u_hsio_3>;
> + phy-names = "p2u-0";
> + };
> +
> + pcie@14160000 {
> + status = "okay";
> + vddio-pex-ctl-supply = <&vdd_1v8_ao>;
> + phys = <&p2u_hsio_7>, <&p2u_hsio_6>, <&p2u_hsio_5>,
> + <&p2u_hsio_4>;
> + phy-names = "p2u-0", "p2u-1", "p2u-2", "p2u-3";
> + };
> +
> + pcie@141a0000 {
> + status = "okay";
> + vddio-pex-ctl-supply = <&vdd_1v8_ls>;
> + phys = <&p2u_nvhs_0>, <&p2u_nvhs_1>, <&p2u_nvhs_2>,
> + <&p2u_nvhs_3>, <&p2u_nvhs_4>, <&p2u_nvhs_5>,
> + <&p2u_nvhs_6>, <&p2u_nvhs_7>;
> + phy-names = "p2u-0", "p2u-1", "p2u-2", "p2u-3", "p2u-4",
> + "p2u-5", "p2u-6", "p2u-7";
> + };
> +
> + pcie@141e0000 {
> + status = "okay";
> + vddio-pex-ctl-supply = <&vdd_1v8_ls>;
> + phys = <&p2u_gbe_0>, <&p2u_gbe_1>;
> + phy-names = "p2u-0", "p2u-1";
> + };
> +
> + aconnect@2900000 {
> + status = "okay";
> + };
> +
> + serial@3100000 {
> + compatible = "nvidia,tegra194-hsuart";
> + status = "okay";
> + };
> +
> + i2c@3160000 {
> + status = "okay";
> + };
> +
> + i2c@3180000 {
> + status = "okay";
> + };
> +
> + i2c@3190000 {
> + status = "okay";
> + };
> +
> + i2c@31b0000 {
> + status = "okay";
> + };
> +
> + i2c@31c0000 {
> + status = "okay";
> +
> + };
> +
> + i2c@31e0000 {
> + status = "okay";
> + };
> +
> + spi@3270000 {
> + status = "okay";
> + };
> +
> + hda@3510000 {
> + nvidia,model = "NVIDIA IGX HDA";
> + status = "okay";
> + };
> +
> + fuse@3810000 {
> + status = "okay";
> + };
> +
> + i2c@c240000 {
> + status = "okay";
> + };
> +
> + i2c@c250000 {
> + status = "okay";
> + };
> + };
> +
> + aliases {
> + serial0 = &tcu;
> + };
> +
> + chosen {
> + bootargs = "console=ttyTCU0,115200n8";
> + stdout-path = "serial0:115200n8";
> + };
This is admittedly a little unintuitive, but "aliases" and "chosen" are
special in that they are ordered at the top of the file (i.e.
immediately before the bus@0 node, and then alphabetically). That's
because they have special meaning, as opposed to the others below which
are just devices that don't have an address region and therefore no
unit-address.
Also, can you try testing this with the "bootargs" property dropped? I
have done some testing on older platforms and that doesn't seem to be
necessary since we have "stdout-path". It'd be good to confirm that it
holds true on IGX and if so we can drop "bootargs". I have work in
progress patches to do this on several other devices.
Thierry
Attachment:
signature.asc
Description: PGP signature
