On Thu, 4 May 2023 at 15:23, Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote: > > On 4.05.2023 10:26, Bhupesh Sharma wrote: > > Add the Embedded USB Debugger(EUD) device tree node for > > SM6115 / SM4250 SoC. > > > > The node contains EUD base register region, EUD mode manager > > register region and TCSR Base register region along with the > > interrupt entry. > > > > Also add the typec connector node for EUD which is attached to > > EUD node via port. EUD is also attached to DWC3 node via port. > > > > To enable the role switch, we need to set dr_mode = "otg" property > > for 'usb_dwc3' sub-node in the board dts file. > > > > Also the EUD device can be enabled on a board once linux is boot'ed > > by setting: > > $ echo 1 > /sys/bus/platform/drivers/qcom_eud/../enable > > > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@xxxxxxxxxx> > > --- > > arch/arm64/boot/dts/qcom/sm6115.dtsi | 48 ++++++++++++++++++++++++++++ > > 1 file changed, 48 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi > > index f67863561f3f..6865342fc42f 100644 > > --- a/arch/arm64/boot/dts/qcom/sm6115.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi > > @@ -180,6 +180,18 @@ core3 { > > }; > > }; > > > > + eud_typec: connector { > > + compatible = "usb-c-connector"; > > + > > + ports { > > + port@0 { > > + con_eud: endpoint { > > + remote-endpoint = <&eud_con>; > > + }; > > + }; > > + }; > > + }; > > + > > firmware { > > scm: scm { > > compatible = "qcom,scm-sm6115", "qcom,scm"; > > @@ -647,6 +659,35 @@ gcc: clock-controller@1400000 { > > #power-domain-cells = <1>; > > }; > > > > + eud: eud@1610000 { > > + compatible = "qcom,sm6115-eud", "qcom,eud"; > > + reg = <0x0 0x01610000 0x0 0x2000>, > > + <0x0 0x01612000 0x0 0x1000>, > > + <0x0 0x003c0000 0x0 0x40000>; > > + interrupts = <GIC_SPI 189 IRQ_TYPE_LEVEL_HIGH>; > > + qcom,secure-mode-enable; > > + status = "disabled"; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > Please insert a newline before each child node. Ok, I will do it in next version. Thanks, Bhupesh