Hi Geert,
Thanks for the feedback.
> -----Original Message-----
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: Wednesday, May 3, 2023 11:28 AM
> To: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@xxxxxxxxxx>; Geert Uytterhoeven
> <geert+renesas@xxxxxxxxx>; Magnus Damm <magnus.damm@xxxxxxxxx>; linux-
> renesas-soc@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; Fabrizio Castro
> <fabrizio.castro.jz@xxxxxxxxxxx>
> Subject: Re: [PATCH 1/2] arm64: dts: renesas: r9a07g044: Add gpu cooling
> device
>
> Hi Biju,
>
> On Tue, Apr 25, 2023 at 5:52 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> > Add gpu cooling device for passive control.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> > @@ -970,6 +970,7 @@ gpu: gpu@11840000 {
> > <&cpg R9A07G044_GPU_ACE_RESETN>;
> > reset-names = "rst", "axi_rst", "ace_rst";
> > operating-points-v2 = <&gpu_opp_table>;
> > + #cooling-cells = <2>;
> > };
> >
> > gic: interrupt-controller@11900000 { @@ -1245,6
> > +1246,11 @@ map0 {
> > cooling-device = <&cpu0 0 2>;
> > contribution = <1024>;
> > };
> > +
> > + map1 {
> > + trip = <&target>;
> > + cooling-device = <&gpu 0 2>;
>
> Perhaps this needs a "contribution" property, as the CPU device in the same
> zone has one?
OK, will check this.
Cheers,
Biju
>
> > + };
> > };
> >
> > trips {
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like
> that.
> -- Linus Torvalds
