Hi Michal, Thank you for the patch. On Tue, May 02, 2023 at 03:51:01PM +0200, Michal Simek wrote: > This reverts commit c6badbd2d321c19d4f55ee56b0ef12bb3352feac. > > Long time ago this was discussed with Rob at link below that there is no > need to add address-cells to gpio and interrupt nodes that's why reverting > this patch for ZynqMP. > Also there is no visible DTC warning which was seen in past. > > Link: https://lore.kernel.org/r/91e3405245c89f134676449cf3822285798d2ed2.1612189652.git.michal.simek@xxxxxxxxxx > Signed-off-by: Michal Simek <michal.simek@xxxxxxx> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > --- > > arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > index 51b8349dcacd..2d564ba7e9e4 100644 > --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > @@ -419,7 +419,6 @@ fpd_dma_chan8: dma-controller@fd570000 { > > gic: interrupt-controller@f9010000 { > compatible = "arm,gic-400"; > - #address-cells = <0>; > #interrupt-cells = <3>; > reg = <0x0 0xf9010000 0x0 0x10000>, > <0x0 0xf9020000 0x0 0x20000>, > @@ -633,7 +632,6 @@ gem3: ethernet@ff0e0000 { > gpio: gpio@ff0a0000 { > compatible = "xlnx,zynqmp-gpio-1.0"; > status = "disabled"; > - #address-cells = <0>; > #gpio-cells = <0x2>; > gpio-controller; > interrupt-parent = <&gic>; -- Regards, Laurent Pinchart