On 5/2/23 11:26, Vincent Legoll wrote: > Hello, > > On Mon, May 1, 2023 at 8:44 AM Cristian Ciocaltea > <cristian.ciocaltea@xxxxxxxxxxxxx> wrote: >> This patch series adds OTP memory support for Rockchip RK3588 SoC, >> while also providing a few improvements to the existing rockchip-otp >> driver, in addition to converting the bindings to dt-schema. > > I tested this on a QuartzPro64 dev board, I applied your series top of my tree: > Collabora's rk3588-v6.3 + some DT patches to add support for the qp64 board. > > Here is the output from the commands you told me to try: > > # ls -1 /sys/bus/nvmem/devices/*/nvmem > /sys/bus/nvmem/devices/rockchip-otp0/nvmem > > # od -N 64 -A x -t x1z -v /sys/bus/nvmem/devices/rockchip-otp0/nvmem > 000000 52 4b 35 88 91 fe 21 41 5a 43 39 36 00 00 00 00 >RK5...!AZC96....< > 000010 00 00 00 00 0f 0b 0d 0a 0a 0c 25 0e 00 00 00 00 >..........%.....< > 000020 00 00 00 00 00 00 00 00 08 0c 00 00 00 00 00 00 >................< > 000030 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 >................< > 000040 > > This is working as expected. > > You can add my T-B, for the whole series: > > Tested-by: Vincent Legoll <vincent.legoll@xxxxxxxxx> Thanks for testing! Regards, Cristian