On Fri 2014-11-21 09:39:06, Sakari Ailus wrote: > Hi Pavel, > > On Thu, Nov 20, 2014 at 09:53:50PM +0100, Pavel Machek wrote: > > Hi! > > > > On Thu 2014-11-20 17:03:49, Sakari Ailus wrote: > > > On Thu, Nov 20, 2014 at 02:17:13PM +0100, Pavel Machek wrote: > > > > > > diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt > > > > index 2d88816..e9acbbc 100644 > > > > --- a/Documentation/devicetree/bindings/leds/common.txt > > > > +++ b/Documentation/devicetree/bindings/leds/common.txt > > > > @@ -14,6 +14,15 @@ Optional properties for child nodes: > > > > "ide-disk" - LED indicates disk activity > > > > "timer" - LED flashes at a fixed, configurable rate > > > > > > > > +- max-microamp : maximum intensity in microamperes of the LED > > > > + (torch LED for flash devices) > > > > +- flash-max-microamp : maximum intensity in microamperes of the > > > > + flash LED; it is mandatory if the LED should > > > > + support the flash mode > > > > +- flash-timeout-microsec : timeout in microseconds after which the flash > > > > + LED is turned off > > > > > > It might be good to add a note that these may be arrays, depending on the > > > device. > > > > No, they really can't be arrays. AFAICT common.txt describes single > > LED, not array of them, and I don't think it is good idea to change > > that. > > Right, if it describes a LED only, and not its controller, I guess it's > fine. Yes, this should describe one LED. Bryan Wu <cooloney@xxxxxxxxx> wanted me to get your ack. Can I have one? > Some controllers can drive multiple flash LEDs at the same time and these > need to be e.g. strobed together, and sometimes not; there are controllers > that support both so it's up to the use case. That's probably more up to the > driver though. Yes. Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
