Hi, Am Montag, 1. Mai 2023, 10:43:54 CEST schrieb Cristian Ciocaltea: > Document the OTP memory found on Rockchip RK3588 SoC. nit: I guess the changed clock and resets configuration for rk3588 variants could be mentioned in the commit message. Reviewed-by: Heiko Stuebner <heiko@xxxxxxxxx> > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@xxxxxxxxxxxxx> > --- > .../bindings/nvmem/rockchip-otp.yaml | 71 ++++++++++++++++--- > 1 file changed, 60 insertions(+), 11 deletions(-) > > diff --git a/Documentation/devicetree/bindings/nvmem/rockchip-otp.yaml b/Documentation/devicetree/bindings/nvmem/rockchip-otp.yaml > index 658ceed14ee2..84a11382c6e7 100644 > --- a/Documentation/devicetree/bindings/nvmem/rockchip-otp.yaml > +++ b/Documentation/devicetree/bindings/nvmem/rockchip-otp.yaml > @@ -9,34 +9,31 @@ title: Rockchip internal OTP (One Time Programmable) memory > maintainers: > - Heiko Stuebner <heiko@xxxxxxxxx> > > -allOf: > - - $ref: nvmem.yaml# > - > properties: > compatible: > enum: > - rockchip,px30-otp > - rockchip,rk3308-otp > + - rockchip,rk3588-otp > > reg: > maxItems: 1 > > clocks: > minItems: 3 > - maxItems: 3 > + maxItems: 4 > > clock-names: > - items: > - - const: otp > - - const: apb_pclk > - - const: phy > + minItems: 3 > + maxItems: 4 > > resets: > - maxItems: 1 > + minItems: 1 > + maxItems: 3 > > reset-names: > - items: > - - const: phy > + minItems: 1 > + maxItems: 3 > > required: > - compatible > @@ -46,6 +43,58 @@ required: > - resets > - reset-names > > +allOf: > + - $ref: nvmem.yaml# > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - rockchip,px30-otp > + - rockchip,rk3308-otp > + then: > + properties: > + clocks: > + minItems: 3 > + maxItems: 3 > + clock-names: > + items: > + - const: otp > + - const: apb_pclk > + - const: phy > + resets: > + maxItems: 1 > + reset-names: > + items: > + - const: phy > + > + - if: > + properties: > + compatible: > + contains: > + enum: > + - rockchip,rk3588-otp > + then: > + properties: > + clocks: > + minItems: 4 > + maxItems: 4 > + clock-names: > + items: > + - const: otpc > + - const: apb > + - const: arb > + - const: phy > + resets: > + minItems: 1 > + maxItems: 3 > + reset-names: > + items: > + - const: otpc > + - const: apb > + - const: arb > + > unevaluatedProperties: false > > examples: >
