> On 1 May 2023, at 7:51 pm, Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> wrote: > > Hi Dmitry, > > On Wed, Apr 26, 2023 at 11:58 AM Dmitry Rokosov > <ddrokosov@xxxxxxxxxxxxxx> wrote: >> >> Add the documentation for Amlogic A1 Peripherals clock driver, >> and A1 Peripherals clock controller bindings. > Maybe a native English speaker can comment on whether it's > "peripheral" or "peripherals". I’m not a grammar specialist, but I would write: “Add documentation and bindings for the Amlogic A1 SoC peripherals clock driver” Peripherals is the correct plural but reads better when you add context on the type of peripherals. Christian > [...] >> Signed-off-by: Jian Hu <jian.hu@xxxxxxxxxxx> >> Signed-off-by: Dmitry Rokosov <ddrokosov@xxxxxxxxxxxxxx> >> Reviewed-by: Rob Herring <robh@xxxxxxxxxx> >> --- >> .../bindings/clock/amlogic,a1-clkc.yaml | 73 +++++++++++ >> .../bindings/clock/amlogic,a1-pll-clkc.yaml | 5 +- >> include/dt-bindings/clock/amlogic,a1-clkc.h | 114 ++++++++++++++++++ > I have seen that Yu Tu named the S4 peripheral clock controller > binding and driver "s4-peripherals-clkc" [0]. > Does it make sense to apply the same naming here as well? > > > Best regards, > Martin > > > [0] https://lore.kernel.org/linux-amlogic/20230417065005.24967-3-yu.tu@xxxxxxxxxxx/ > > _______________________________________________ > linux-amlogic mailing list > linux-amlogic@xxxxxxxxxxxxxxxxxxx > http://lists.infradead.org/mailman/listinfo/linux-amlogic
