On 28/04/2023 01:30, Jakob Hauser wrote: > Add device tree binding documentation for rt5033 multifunction device, voltage > regulator and battery charger. > > Cc: Beomho Seo <beomho.seo@xxxxxxxxxxx> > Cc: Chanwoo Choi <cw00.choi@xxxxxxxxxxx> > Signed-off-by: Jakob Hauser <jahau@xxxxxxxxxxxxxx> (...) > + > +required: > + - monitored-battery > + > +additionalProperties: false > + > +examples: > + - | > + charger { > + compatible = "richtek,rt5033-charger"; > + monitored-battery = <&battery>; > + extcon = <&muic>; Everything up to here looked ok, but extcon is not a hardware property. Please do not mix adding missing bindings for existing device with adding new properties. You should use connector for the USB port. Best regards, Krzysztof