On 4/27/23 16:48, Marijn Suijten wrote: > On 2023-04-27 17:37:42, Marijn Suijten wrote: >> On 2023-04-21 00:31:16, Konrad Dybcio wrote: >>> Add SM6350 support to the DPU1 driver to enable display output. >>> >>> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxx> >>> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> >> After addressing the comments from Dmitry (CURSOR0->DMA1 and >> CURSOR1->DMA2), this is: >> >> Reviewed-by: Marijn Suijten <marijn.suijten@xxxxxxxxxxxxxx> >> >> See below for some nits. > Actually found one glaring issue that might explain why INTF TE wasn't > working for you the other day! [...] >>> + .vbif = sm6350_vbif, >>> + .reg_dma_count = 1, >>> + .dma_cfg = &sm8250_regdma, >>> + .perf = &sm6350_perf_data, >>> + .mdss_irqs = BIT(MDP_SSPP_TOP0_INTR) | \ >>> + BIT(MDP_SSPP_TOP0_INTR2) | \ >>> + BIT(MDP_SSPP_TOP0_HIST_INTR) | \ >>> + BIT(MDP_INTF0_INTR) | \ >>> + BIT(MDP_INTF1_INTR) > For completeness I should've pointed out that you're missing > MDP_INTF1_TEAR_INTR here, likely resulting in INTF TE not working. > > - Marijn <annoyed noises> so it might have been this.. I'll retest, thanks! Konrad > > <snip>
