On 28/04/2023 16:34, Nikita Shubin wrote: > On Tue, 2023-04-25 at 11:29 +0200, Krzysztof Kozlowski wrote: >> On 24/04/2023 14:34, Nikita Shubin wrote: >>> This adds device tree bindings for the Cirrus Logic EP93xx >>> timer block used in these SoCs. >>> >>> Signed-off-by: Nikita Shubin <nikita.shubin@xxxxxxxxxxx> >>> --- >>> >>> Notes: >>> Arnd Bergmann: >>> - replaced ep93xx wildcard with ep9301 >>> >>> .../bindings/timer/cirrus,ep93xx-timer.yaml | 41 >>> +++++++++++++++++++ >>> 1 file changed, 41 insertions(+) >>> create mode 100644 >>> Documentation/devicetree/bindings/timer/cirrus,ep93xx-timer.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/timer/cirrus,ep93xx- >>> timer.yaml b/Documentation/devicetree/bindings/timer/cirrus,ep93xx- >>> timer.yaml >>> new file mode 100644 >>> index 000000000000..ce8b8a5cb90a >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/timer/cirrus,ep93xx- >>> timer.yaml >>> @@ -0,0 +1,41 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/timer/cirrus,ep93xx-timer.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Cirrus Logic EP93xx timers bindings >>> + >>> +maintainers: >>> + - Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx> >>> + - Alexander Sverdlin <alexander.sverdlin@xxxxxxxxx> >>> + >>> +properties: >>> + compatible: >>> + const: cirrus,ep9301-timer >> >> 1. Why only one compatible? >> 2. If this is kept, then filename matching compatible. > > I should rename the file to cirrus,ep9301-timer.yaml No, at least no yet. See point 1. Best regards, Krzysztof
