Hi Angelo, On Thu, 2023-04-27 at 17:15 +0200, AngeloGioacchino Del Regno wrote: > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > Il 26/04/23 13:43, AngeloGioacchino Del Regno ha scritto: > > Il 12/09/22 03:29, Jason-JH.Lin ha scritto: > > > Since the gamma_set_common() function for previous SoC, > > > such as mt8173 and mt8183, is designed for 9bit-to-10bit > > > conversion. > > > mt8195 is using 10bit-to-12bit conversion, which is > > > not compatible with the previous function. > > > > > > Thus, need to update the function to fit the need of mt8195. > > > > Hello, > > can you please respin and fix this series on the latest linux-next? > > > > Besides, please test it carefully: as far as I can see, GNOME Night > > Light > > (or others) are not working on MT8195 (color temperature/ccorr). > > As for gamma itself, that's not working either; you can test it > > with a tool > > that will create a color profile by applying a new VCGT table, > > please look > > at [1] if you need tools. > > > > We can confirm that color correction works on at least MT8192 > > (colord), so > > it's MT8195 at fault. > > > > [1]: > > https://urldefense.com/v3/__https://github.com/zb3/gnome-gamma-tool__;!!CTRNKA9wMg0ARbw!ib5vs_mqKWlyC8VbLNZbc4Fc0-e6dL5Z-OM5pLsVRnQOWAckR6ETV1mRYRkz-5rKB7fdYvY4LrYoHKDlv6jPSKzoC-245JTYaQ$ > > > > Nevermind. I've actually fixed this code and refactored it a bit as > well. > > I'll push my own version soon. No action required. > > Regards, > Angelo > OK~ Thanks for your great help! :) Regards, Jason-JH.Lin
