On Fri, Apr 21, 2023 at 8:28 AM Mehta, Piyush <piyush.mehta@xxxxxxx> wrote: > > Hi > > > -----Original Message----- > > From: Rob Herring <robh@xxxxxxxxxx> > > Sent: Wednesday, April 19, 2023 12:10 AM > > To: Mehta, Piyush <piyush.mehta@xxxxxxx> > > Cc: gregkh@xxxxxxxxxxxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; > > michal.simek@xxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; > > devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Simek, Michal > > <michal.simek@xxxxxxx>; Paladugu, Siva Durga Prasad > > <siva.durga.prasad.paladugu@xxxxxxx>; linux-arm- > > kernel@xxxxxxxxxxxxxxxxxxx; git (AMD-Xilinx) <git@xxxxxxx> > > Subject: Re: [PATCH] dt-bindings: usb: dwc3: xilinx: Add interrupt-names to > > include hibernation interrupt > > > > On Wed, Apr 12, 2023 at 11:38:43AM +0530, Piyush Mehta wrote: > > > The hibernation feature enabled for Xilinx Versal NET SoC in DWC3 IP. > > > Added host mode interrupts and "usb-wakeup" interrupt-names optional > > > property in the binding schema to capture remote-wakeup and connect/ > > > disconnect event in the hibernation state. > > > > > > Xilinx dwc3-core uses "host" and "otg" interrupts interrupt-names DT > > > properties from dwc3-core. > > > > Is wakeup really not implemented in the DWC3 core, but outside it? > > Wakeup is implemented inside the dwc3-core. Then it goes in the dwc3 node. > Initially we planned to implement wakeup interrupt name/interrupt optional property in the dwc3-core. > However, looking at other vendor wakeup interrupt implementation (Commit: dd566faebe9f dt-bindings: usb: qcom,dwc3: refine interrupt requirements) > we moved wakeup property to xilinx USB binding. That one looks like the phy implements wake-up? I don't know really, but doesn't seem like one to copy. Rob
