Re: [PATCH v1 1/2] dt-bindings: net: motorcomm: Add pad driver strength cfg From: Frank Sae <Frank.Sae@xxxxxxxxxxxxxx> to: Samin Guo <samin.guo@xxxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <devicetree@xxxxxxxxxxxxxxx>, <netdev@xxxxxxxxxxxxxxx>, Peter Geis <pgwipeout@xxxxxxxxx> data: 2023/4/26 > > > On 2023/4/26 14:35, Samin Guo wrote: >> The motorcomm phy (YT8531) supports the ability to adjust the drive >> strength of the rx_clk/rx_data, the value range of pad driver >> strength is 0 to 7. >> >> Signed-off-by: Samin Guo <samin.guo@xxxxxxxxxxxxxxxx> >> --- >> .../devicetree/bindings/net/motorcomm,yt8xxx.yaml | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml b/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml >> index 157e3bbcaf6f..e648e486b6d8 100644 >> --- a/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml >> +++ b/Documentation/devicetree/bindings/net/motorcomm,yt8xxx.yaml >> @@ -18,6 +18,16 @@ properties: >> - ethernet-phy-id4f51.e91a >> - ethernet-phy-id4f51.e91b >> >> + rx-clk-driver-strength: >> + description: drive strength of rx_clk pad. >> + enum: [ 0, 1, 2, 3, 4, 5, 6, 7 ] >> + default: 3 >> + >> + rx-data-driver-strength: >> + description: drive strength of rxd/rx_ctl rgmii pad. >> + enum: [ 0, 1, 2, 3, 4, 5, 6, 7 ] >> + default: 3 >> + > > rx-clk-driver-strength and rx-data-driver-strength are not standard, so please add "motorcomm,". > rx-clk-driver-strength => motorcomm,rx-clk-driver-strength > Thanks, I will fix it next version. Best regards, Samin > >> rx-internal-delay-ps: >> description: | >> RGMII RX Clock Delay used only when PHY operates in RGMII mode with