Hi Andrew, > -----Original Message----- > From: Andrew Lunn <andrew@xxxxxxx> > Sent: Wednesday, April 26, 2023 7:18 PM > To: Katakam, Harini <harini.katakam@xxxxxxx> > Cc: robh+dt@xxxxxxxxxx; hkallweit1@xxxxxxxxx; linux@xxxxxxxxxxxxxxx; > davem@xxxxxxxxxxxxx; kuba@xxxxxxxxxx; edumazet@xxxxxxxxxx; > pabeni@xxxxxxxxxx; vladimir.oltean@xxxxxxx; wsa+renesas@sang- > engineering.com; krzysztof.kozlowski+dt@xxxxxxxxxx; > simon.horman@xxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > harinikatakamlinux@xxxxxxxxx; Simek, Michal <michal.simek@xxxxxxx>; > Pandey, Radhey Shyam <radhey.shyam.pandey@xxxxxxx> > Subject: Re: [PATCH net-next v2 3/3] phy: mscc: Add support for VSC8531_02 > with RGMII tuning > > On Wed, Apr 26, 2023 at 04:13:13PM +0530, Harini Katakam wrote: > > From: Harini Katakam <harini.katakam@xxxxxxxxxx> > > > > Add support for VSC8531_02 (Rev 2) device. > > Add support for optional RGMII RX and TX delay tuning via devicetree. > > The hierarchy is: > > - Retain the defaul 0.2ns delay when RGMII tuning is not set. > > - Retain the default 2ns delay when RGMII tuning is set and DT delay > > property is NOT specified. > > tuning is probably the wrong word here. I normally consider tuning as small > changes from 0ns/2ns. The course setting of 0ns or 2ns is not tuning. I > normally use RGMII internal delays to refer to that. > > However, i'm not sure there is consistency among drivers. Thanks for the input, I understand. I'm planning on re-phrasing this with phy-mode and property values to describe rather than say tuning. Regards, Harini
