On Mon, Apr 24, 2023 at 03:53:07PM +0200, Krzysztof Kozlowski wrote: > On 23/04/2023 14:40, Stanislav Jakubek wrote: > > Convert Broadcom Kona family I2C bindings to DT schema. > > > > Changes during conversion: > > - add used, but previously undocumented SoC-specific compatibles > > - drop references to SoCs that are not upstream > > - add supported clock frequencies according to the Linux driver [1] > > > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/i2c/busses/i2c-bcm-kona.c#n731 > > This line points to moving reference in next, so might no be accurate > later. If you need external reference, then it should be some stable > tag. But anyway if this is in mainline (is this?) then, why referencing > via external link? Yes, it's in mainline since 2013. I just pointed to linux-next since that was what I had open at the time. Just to make sure if I understood correctly, if it's in mainline then there's no need to reference it via link? Or should I point to some tag instead, e.g.: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/i2c/busses/i2c-bcm-kona.c?h=v6.3#n731 Thank you for the review, Stanislav > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > Best regards, > Krzysztof >