On Wed, Apr 26, 2023 at 04:13:11PM +0530, Harini Katakam wrote:
> All the PHY devices variants specified have the same mask and
> hence can be simplified to one vendor look up for 0xfffffff0.
> Any individual config can be identified by PHY_ID_MATCH_EXACT
> in the respective structure.
>
> Signed-off-by: Harini Katakam <harini.katakam@xxxxxxx>
net-next is closed at the moment, so you will need to report in two
weeks time.
> diff --git a/drivers/net/phy/mscc/mscc_main.c b/drivers/net/phy/mscc/mscc_main.c
> index 62bf99e45af1..75d9582e5784 100644
> --- a/drivers/net/phy/mscc/mscc_main.c
> +++ b/drivers/net/phy/mscc/mscc_main.c
> @@ -2656,19 +2656,7 @@ static struct phy_driver vsc85xx_driver[] = {
> module_phy_driver(vsc85xx_driver);
>
> static struct mdio_device_id __maybe_unused vsc85xx_tbl[] = {
> - { PHY_ID_VSC8504, 0xfffffff0, },
> - { PHY_ID_VSC8514, 0xfffffff0, },
> - { PHY_ID_VSC8530, 0xfffffff0, },
> - { PHY_ID_VSC8531, 0xfffffff0, },
> - { PHY_ID_VSC8540, 0xfffffff0, },
> - { PHY_ID_VSC8541, 0xfffffff0, },
> - { PHY_ID_VSC8552, 0xfffffff0, },
> - { PHY_ID_VSC856X, 0xfffffff0, },
> - { PHY_ID_VSC8572, 0xfffffff0, },
> - { PHY_ID_VSC8574, 0xfffffff0, },
> - { PHY_ID_VSC8575, 0xfffffff0, },
> - { PHY_ID_VSC8582, 0xfffffff0, },
> - { PHY_ID_VSC8584, 0xfffffff0, },
> + { PHY_ID_MATCH_VENDOR(0xfffffff0) },
The vendor ID is 0xfffffff0 ???
Andrew
