On Wed, Nov 19, 2014 at 10:52:47AM -0800, Kenneth Westfield wrote: > +++ b/sound/soc/qcom/Kconfig > @@ -0,0 +1,43 @@ > +# > +# Copyright (c) 2013-2014 The Linux Foundation. All rights reserved. Is there some kind of copyright assignment on file or something? It's weird to have someone else without obvious authorship own the copyright... > +# Permission to use, copy, modify, and/or distribute this software for any > +# purpose with or without fee is hereby granted, provided that the above > +# copyright notice and this permission notice appear in all copies. > +# > +# THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES > +# WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF > +# MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR > +# ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES > +# WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN > +# ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF > +# OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. Please just license the file under the GPL, all the drivers that get built from here are GPLed - I can't see any reason for this to have an odd license. > +config SND_SOC_QCOM > + bool "SoC Audio support for QCOM platforms" > + help > + Support for audio in Qualcomm Technologies SOC-based systems. > + Say Y if you want to use audio devices that will run on IPQ806x and similar SOCs. > + I'd expect this to be the first thing in the file not the last. Why are things in here bools, shouldn't they be tristates? > index 0000000000000000000000000000000000000000..0a74177df75f7aa5f7fbaab35da9b92689fa3d6a > --- /dev/null > +++ b/sound/soc/qcom/Makefile > @@ -0,0 +1,11 @@ > +#QCOM SOUNDCARDS > + This appears to be CPU drivers as well as sound cards (as you'd expect for machine drivers) so the comment isn't quite right - just remove it.
Attachment:
signature.asc
Description: Digital signature
