On Fri, Apr 14, 2023 at 6:47 PM Mark Brown <broonie@xxxxxxxxxx> wrote: > > On Fri, Apr 14, 2023 at 04:01:54PM +0200, Paweł Anikiel wrote: > > > sound/soc/Makefile | 1 + > > sound/soc/chameleonv3/Kconfig | 7 + > > sound/soc/chameleonv3/Makefile | 2 + > > sound/soc/chameleonv3/chv3-audio.c | 111 ++++++ > > sound/soc/chameleonv3/chv3-i2s.c | 347 ++++++++++++++++++ > > sound/soc/chameleonv3/chv3-it68051.c | 41 +++ > > Please at least make a directory for Google as a vendor, we don't want > people adding directories for each individual product. That said > generally we add machine drivers in the directory for the relevant SoC > family, is there any reason that pattern isn't followed here? The board is based around an Intel Arria 10 SoC FPGA. The ring buffer device and all the routing is implemented inside the FPGA. Is it ok to put the machine driver in the product directory in this case?. As for the directory path, would sound/soc/google/chameleonv3/* be ok? Regards, Paweł