On 4/24/23 18:22, Andy Shevchenko wrote:
On Mon, Apr 24, 2023 at 04:10:09PM +0300, Matti Vaittinen wrote:
The ROHM BU27008 is a sensor with 5 photodiodes (red, green, blue, clear
and IR) with four configurable channels. Red and green being always
available and two out of the rest three (blue, clear, IR) can be
selected to be simultaneously measured. Typical application is adjusting
LCD backlight of TVs, mobile phones and tablet PCs.
Add initial support for the ROHM BU27008 color sensor.
- raw_read() of RGB and clear channels
- triggered buffer w/ DRDY interrtupt
...
This...
+#include <linux/bits.h>
...is guaranteed to be included by this.
+#include <linux/bitops.h>
Out of the curiosity - do we have a rule and rationale for explicitly
including headers with 'stuff' we use Vs. trusting some header being
included by another one? I've not thought much of this so I don't know
if there are any pros/cons?
...
+static const struct of_device_id bu27008_of_match[] = {
+ { .compatible = "rohm,bu27008", },
Inner comma is not necessary to have.
Thanks.
Yours,
-- Matti
--
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland
~~ When things go utterly wrong vim users can always type :help! ~~
