On Mon, Apr 24, 2023 at 03:34:44PM +0300, Nikita Shubin wrote: > Add YAML bindings for ST M48T86 / Dallas DS12887 RTC. > > Signed-off-by: Nikita Shubin <nikita.shubin@xxxxxxxxxxx> > --- > .../bindings/rtc/dallas,rtc-m48t86.yaml | 33 +++++++++++++++++++ > 1 file changed, 33 insertions(+) > create mode 100644 Documentation/devicetree/bindings/rtc/dallas,rtc-m48t86.yaml > > diff --git a/Documentation/devicetree/bindings/rtc/dallas,rtc-m48t86.yaml b/Documentation/devicetree/bindings/rtc/dallas,rtc-m48t86.yaml > new file mode 100644 > index 000000000000..51f98bdbc385 > --- /dev/null > +++ b/Documentation/devicetree/bindings/rtc/dallas,rtc-m48t86.yaml > @@ -0,0 +1,33 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/rtc/dallas,rtc-m48t86.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ST M48T86 / Dallas DS12887 RTC bindings > + > +maintainers: > + - Alessandro Zummo <a.zummo@xxxxxxxxxxxx> > + > +properties: > + compatible: > + const: dallas,rtc-m48t86 'rtc-' is redundant. And haven't you mixed up the vendor and part number? It should be dallas,ds12887 and/or st,m48t86? This can probably go in the trivial rtc binding. > + > + reg: > + maxItems: 2 > + > +required: > + - compatible > + - reg > + > +additionalProperties: false > + > +examples: > + - | > + rtc1: rtc@10800000 { Drop unused labels. > + compatible = "dallas,rtc-m48t86"; > + reg = <0x10800000 0x1>, <0x11700000 0x1>; > + }; > + > +... > + > -- > 2.39.2 >
