Hi Manivannan,
> From: Manivannan Sadhasivam, Sent: Saturday, April 22, 2023 10:59 PM
>
> On Tue, Apr 18, 2023 at 09:23:55PM +0900, Yoshihiro Shimoda wrote:
> > Expose dw_pcie_ep_exit() to module.
> >
>
> This is not a good commit message. You need to mention why it is needed and list
> any breakage observed without this.
I'll modify description like below:
Since no PCIe controller drivers call this, this change is not required
for now. But, Renesas R-Car S4-8 PCIe controller driver will call this
and if the controller driver is built as a kernel module, the following
build error happens. So, expose dw_pcie_ep_exit() for it.
ERROR: modpost: "dw_pcie_ep_exit" [drivers/pci/controller/dwc/pcie-rcar-gen4-ep-drv.ko] undefined!
Best regards,
Yoshihiro Shimoda
> - Mani
>
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> > ---
> > drivers/pci/controller/dwc/pcie-designware-ep.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c
> > index 304ed093f551..2458ca2bc0e4 100644
> > --- a/drivers/pci/controller/dwc/pcie-designware-ep.c
> > +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c
> > @@ -681,6 +681,7 @@ void dw_pcie_ep_exit(struct dw_pcie_ep *ep)
> >
> > pci_epc_mem_exit(epc);
> > }
> > +EXPORT_SYMBOL_GPL(dw_pcie_ep_exit);
> >
> > static unsigned int dw_pcie_ep_find_ext_capability(struct dw_pcie *pci, int cap)
> > {
> > --
> > 2.25.1
> >
>
> --
> மணிவண்ணன் சதாசிவம்
