On 22/04/2023 15:50, Artur Weber wrote:
> Hi,
>
> thank you for the review.
>
> On 16/04/2023 20:26, Krzysztof Kozlowski wrote:
>> On 16/04/2023 15:34, Artur Weber wrote:
>> [...]
>>> +
>>> + backlight: backlight@2c {
>>> + compatible = "ti,lp8556";
>>
>> You need to convert bindings to DT schema first. I don't accept any new
>> usages of TXT bindings anymore, sorry.
>>
>
> I'll be taking a look at the conversion (will likely submit it as a
> separate patchset, since I've been looking into some minor driver-side
> changes there as well...), although I have one question - who should I
> list as the bindings maintainer ("maintainers" field in YAML format)? Is
Anyone who has interest in the device/driver, like driver maintainer,
device developers, you erc.
> this someone specific for that subsystem, or the author of the driver,
> or someone else? (It's worth noting that there isn't a maintainer listed
> for the lp855x driver in the MAINTAINERS file.)
> Documentation/devicetree/bindings/writing-schema.rst doesn't really
> mention anything about this.
>
>>> +&bus_acp {
>>
>> Order label/phandle overrides by name, so acp before dmc.
>>
>
> Out of curiosity - should I order the children of the / node
Yes.
> or the
> pinctrl nodes by name as well?
These are usually by pin name.
Best regards,
Krzysztof
