On 21/04/2023 14:41, Devi Priya wrote: > Add bindings for the PCIe QMP PHYs found on IPQ9574. > > Signed-off-by: Devi Priya <quic_devipriy@xxxxxxxxxxx> > --- > Changes in V1: > - Introduced a new binding for ipq9574 as suggested by Krzysztof It looks it depends on the clock header. Either mention the dependency here or better convert the clock IDs to numerical values. With the second approach the patch can be applied independently from clock headers patch. > > .../phy/qcom,ipq9574-qmp-pcie-phy.yaml | 90 +++++++++++++++++++ > 1 file changed, 90 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/qcom,ipq9574-qmp-pcie-phy.yaml > Assuming you tested it (as Rob's bot cannot due to dependency): Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof