Please see inline > -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Sent: Thursday, April 20, 2023 1:48 AM > To: Bharat Bhushan <bbhushan2@xxxxxxxxxxx>; wim@xxxxxxxxxxxxxxxxxx; > linux@xxxxxxxxxxxx; robh+dt@xxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; > linux-watchdog@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx; Sunil Kovvuri Goutham <sgoutham@xxxxxxxxxxx> > Subject: [EXT] Re: [PATCH 1/2 v2] dt-bindings: watchdog: marvell octeonTX2 GTI > system watchdog driver > > External Email > > ---------------------------------------------------------------------- > On 19/04/2023 14:06, Bharat Bhushan wrote: > > Add binding documentation for the Marvell octeonTX2 GTI system > > watchdog driver. > > > > Signed-off-by: Bharat Bhushan <bbhushan2@xxxxxxxxxxx> > > --- > > v2: > > - compatible changed from marvell-octeontx2-wdt to > > marvell,octeontx2-wdt > > - corrected type atchdog to watchdog > > - Replaced hardcoding to use IRQ_TYPE_EDGE_RISING flag > > > > .../watchdog/marvell,octeontx2-wdt.yaml | 46 +++++++++++++++++++ > > 1 file changed, 46 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/watchdog/marvell,octeontx2-wdt.yaml > > > > diff --git > > a/Documentation/devicetree/bindings/watchdog/marvell,octeontx2-wdt.yam > > l > > b/Documentation/devicetree/bindings/watchdog/marvell,octeontx2-wdt.yam > > l > > new file mode 100644 > > index 000000000000..96a979c4082d > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/watchdog/marvell,octeontx2-wdt > > +++ .yaml > > @@ -0,0 +1,46 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > > +--- > > +$id: > > +https://urldefense.proofpoint.com/v2/url?u=http-3A__devicetree.org_sc > > +hemas_watchdog_marvell-2Cocteontx2-2Dwdt.yaml- > 23&d=DwICaQ&c=nKjWec2b6 > > > +R0mOyPaz7xtfQ&r=PAAlWswPe7d8gHlGbCLmy2YezyK7O3Hv_t2heGnouBw&m > =hfb7o-i > > +4kbdpZCZqCfL3wODwKTKYMqbBAjxBKX- > 85IvuNz7570vucV6zfDurB06Q&s=OyBAJhs9o > > +rlzygpBvz9_J9QqbMvx4VStrLu1v4bz09Y&e= > > +$schema: > > +https://urldefense.proofpoint.com/v2/url?u=http-3A__devicetree.org_me > > +ta-2Dschemas_core.yaml- > 23&d=DwICaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=PAAlWsw > > +Pe7d8gHlGbCLmy2YezyK7O3Hv_t2heGnouBw&m=hfb7o- > i4kbdpZCZqCfL3wODwKTKYMq > > +bBAjxBKX-85IvuNz7570vucV6zfDurB06Q&s=nkEezAESMoQl- > 1jXRbNmHRErNfyKicAz > > +DzwdtKiN6Y0&e= > > + > > +title: Marvell OcteonTX2 GTI system watchdog > > + > > +allOf: > > + - $ref: watchdog.yaml# > > + > > +maintainers: > > + - Bharat Bhushan <bbhushan2@xxxxxxxxxxx> > > + > > +properties: > > + compatible: > > + const: marvell,octeontx2-wdt > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + > > +unevaluatedProperties: false > > + > > +examples: > > + - | > > + #include <dt-bindings/interrupt-controller/irq.h> > > + soc { > > + #address-cells = <2>; > > + #size-cells = <2>; > > + > > + watchdog@802000040000 { > > + compatible = "marvell,octeontx2-wdt"; > > Mixed indentation. Use 4 spaces for entire DTS example (or 2 spaces, but > 4 is preferred). Will fix in next version. Thanks -Bharat > > Best regards, > Krzysztof
